Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename annotation to marker #24

Merged
merged 27 commits into from
Jul 27, 2021
Merged

Rename annotation to marker #24

merged 27 commits into from
Jul 27, 2021

Conversation

rytswd
Copy link
Member

@rytswd rytswd commented Jul 22, 2021 •
edited
Loading

Fixes #21

Refactored and Fixed:

  • all occurrences of "annotation" to "marker" (except for the image)

Refactored:

  • regexp usage with dedicated package and function
  • more test cases for some specific use cases
  • moved testdata files into dedicated files based on file type

Fixed:

  • preview command fixed to give updated content correctly

rytswd added 27 commits July 22, 2021 09:24
@rytswd
Replace annotation with marker
7bbe553
@rytswd
Adjust marker note
3a58c60
@rytswd
Rename filenames
393dd4e
@rytswd
Rename annotation to marker in code
f17fd43
@rytswd
Refactor redundant function names
1e80812
@rytswd
Rename to Exporter Marker
c6f1774
@rytswd
Adjust testdata with marker
02bcc87
@rytswd
Rename function back
7bc72f1
@rytswd
Introduce new package for marker and regex
0440a36
@rytswd
Rename function
70bbacf
@rytswd
Fix test cases
a7d2448
@rytswd
Add clarification comment
f0213fe
@rytswd
Refactor use of regexp with map solution
690bb21
@rytswd
Add another test case, minor wording change
256e24c
@rytswd
Comment correction
f28f509
@rytswd
Adjust wording
b9042e9
@rytswd
Remove redundant files
3a7c6f1
@rytswd
Ensure test coverage
f319fe4
@rytswd
Consolidate use of marker to package
a81cc51
@rytswd
Add test case for non-markdown and non-yaml
ac677b1
@rytswd
Add more test cases
a959702
@rytswd
Add print tests
1943c81
@rytswd
Refactor file structure
71a8ab2
@rytswd
Duplicate testdata to type based directories
87e735c
@rytswd
Update testdata usage
43abc70
@rytswd
Correct file references
9dad43b
@rytswd
Move files around and correct references
0c0ce6e
@rytswd rytswd marked this pull request as ready for review July 27, 2021 20:28
@rytswd rytswd merged commit d17da6e into main Jul 27, 2021
@rytswd rytswd deleted the rename-annotation-to-marker branch July 27, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Misc]: Rename all use of the word "annotations" with "markers"
1 participant
@rytswd