Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve execution logging #54

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Jrc356
Copy link
Contributor

@Jrc356 Jrc356 commented Nov 18, 2022

Overview

should close #51

This PR improves the execution logging to make it easier to read and parse. It does this by printing the jobs as a yaml-esk list within github actions log groups.

Each bit of information is grouped:

  • complete jobs
  • incomplete jobs (jobs that are no other status)
  • failed jobs
  • all jobs
  • ignored jobs

Details

  • Prints job details as a yaml-esk list
  • Uses log grouping when printing log groups
  • adds a function to get incomplete jobs

--
Ignored jobs: %+q`, result, s.ignoredJobs)
}
::group::Completed jobs
Copy link
Contributor Author

@Jrc356 Jrc356 Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops, never submitted this comment 😅

@rytswd I know you mentioned in #51 that we should group the details in a single group but I think this might be a better way to organize it and allows end users to see the group of jobs that are most interesting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my delayed response...

I like your approach! My comment was just to illustrate what's possible, so I do agree your approach makes it easier for users 👍

Copy link
Member

@rytswd rytswd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great addition here, LGTM!

--
Ignored jobs: %+q`, result, s.ignoredJobs)
}
::group::Completed jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my delayed response...

I like your approach! My comment was just to illustrate what's possible, so I do agree your approach makes it easier for users 👍

@rytswd
Copy link
Member

rytswd commented Nov 23, 2022

I'm going to merge this already, as the impact is likely contained but very useful for users. Thanks for the great work @Jrc356 !

@rytswd rytswd merged commit 1aec150 into upsidr:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better processing log format
2 participants