Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add storeserver, create pathstyle tag, add go.mod #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elee1766
Copy link

@elee1766 elee1766 commented Mar 16, 2023

hi.

this pr has the following

  1. a store server that loads the s3 implementation
  2. allow setting of the pathstyle through config.
  3. switches to go mod in a similar style to gcp

for my store, i tried to use digitalocean spaces, which is s3 compliant. however, it requires the pathstyle setting to be set to false. I don't really know what the default is, and i do know some providers (i think seaweedfs and minio) require it to be set true. (i do plan to test this driver on seaweedfs soon)

so this code is currently running on my store, it is being compiled by this job https://tuxpa.in/a/upspind and it seems to be working so far.

please let me know if theres anything i need to fix/change. upspin is cool happy to contribute and help the project

@google-cla
Copy link

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant