Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: percentage #16

Merged
merged 4 commits into from
Feb 24, 2023
Merged

fix: percentage #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5108129
fix: percentage
chronark Feb 24, 2023
f767488
fix: percentage
chronark Feb 24, 2023
d1811aa
Merge branch 'percentage' of https://github.com/upstash/edge-flags in…
chronark Feb 24, 2023
c1bab37
fix: percentage
chronark Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions examples/middleware-rewrites/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ import { Client as EdgeFlags } from "@upstash/edge-flags";

const edgeFlags = new EdgeFlags({ redis: Redis.fromEnv() });
export default async function middleware(req: NextRequest): Promise<NextResponse> {
const enabled = await edgeFlags.getFlag("eu-countries", req.geo ?? {}).catch(err => {
console.error(err)
return false
})
const enabled = await edgeFlags.getFlag("eu-countries", req.geo ?? {}).catch((err) => {
console.error(err);
return false;
});

if (!enabled) {
const url = new URL(req.url);
url.pathname = "/blocked";
return NextResponse.rewrite(url);
}
if (!enabled) {
const url = new URL(req.url);
url.pathname = "/blocked";
return NextResponse.rewrite(url);
}

return NextResponse.next();
return NextResponse.next();
}

export const config = {
matcher: "/",
matcher: "/",
};
3 changes: 2 additions & 1 deletion packages/sdk/src/evaluation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ export function evaluate(flag: Flag, userPercentage: number, req: EvalRequest, d
if (flag.percentage) {
if (debug) console.log({ userPercentage, flagPercentage: flag.percentage });

if (userPercentage < flag.percentage) {
if (userPercentage > flag.percentage) {
if (debug) console.log("userPercentage < flag.percentage, returning false");
return false;
}
}
Expand Down
2 changes: 2 additions & 0 deletions packages/sdk/src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export function createEdgeHandler(opts: HandlerConfig): NextMiddleware {
flagName,
opts.environment ?? (process.env.VERCEL_ENV as Environment) ?? "development",
);
if (opts.debug) console.log("found flag", loaded);
headers.set("X-Redis-Latency", (Date.now() - redisStart).toString());
if (loaded) {
flag = loaded;
Expand Down Expand Up @@ -121,6 +122,7 @@ export function createEdgeHandler(opts: HandlerConfig): NextMiddleware {
const percentage = hashSum % 100;

const value = evaluate(flag, percentage, evalRequest, opts.debug);
if (opts.debug) console.log("eval", { evalRequest, percentage, value });

headers.set("X-Edge-Latency", (Date.now() - edgeStart).toString());

Expand Down