Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests #102

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix failing tests #102

merged 2 commits into from
Apr 24, 2024

Conversation

CahidArda
Copy link
Contributor

  • cache test failed because we didn't expect a correct value
  • resetUsedToken test failed because we need to wait for the pending in the case of cachedFixedWindow

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ratelimit-with-vercel-kv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:54am

- increased timeout duration in ratelimit tests
- cache test failed because we didn't expect a correct value
- resetUsedToken test failed because there was a bug in resetUsedToken method and we need to wait for the pending in the case of cachedFixedWindow
@ogzhanolguncu ogzhanolguncu merged commit 8748bdc into main Apr 24, 2024
3 checks passed
@CahidArda CahidArda deleted the fix-tests branch April 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants