Add lua script caching #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this commit, we loaded scripts to redis in every cold start. This is not so desirable because the scripts in the redis cache stay there unless someone calls SCRIPT FLUSH. Hence, a life cycle is needed. How do we define a life cycle for a serverless environment? Random numbers. In each limit() invocation, we create a random number and flush the scripts if it is smaller than some frequency threshold. If a user makes a lot of requests, their scripts will get flushed eventually. This implementation however, has a hazard: serverless instance A can flush while instance B is still operating. We need a 'safeEvalsha' and we add exactly that in hash.ts.
This reverts commit 460eed5.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CahidArda
force-pushed
the
dx-873-hash-scripts
branch
from
a6a1e29
to
f7a4a2f
Compare
ogzhanolguncu
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.