Fix multi region algorithms & Update Analytics with New Methods #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issues: - remaining was equal to the number of requests allowed per window in the first limit call. - remaining was not returned as an integer - synth method didn't calculate allCurrentIds as a set of ids, rather an array of ids which resulted in duplicates - synth method compared previous in db with current in all dbs. Changed it so that current in db is compared with current in all dbs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- fix npm package link - move documentation sections up
|
we should wait for upstash/core-analytics#35 and bump dependency version, than tag ratelimit |
Update analytics with the new core-analytics
CahidArda
changed the title
ogzhanolguncu
previously approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issues in multi region fixed window:
fixed issues in multi region sliding window: