-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX-914: Extend Tests with Index Client #31
Merged
ogzhanolguncu
merged 14 commits into
master
from
dx-914-expand-vectorjs-tests-with-actual-usage-convention
Jun 3, 2024
Merged
DX-914: Extend Tests with Index Client #31
ogzhanolguncu
merged 14 commits into
master
from
dx-914-expand-vectorjs-tests-with-actual-usage-convention
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahreddinozcan
changed the title
Extend Tests with Index Client
DX-914: Extend Tests with Index Client
May 29, 2024
ogzhanolguncu
previously approved these changes
Jun 3, 2024
CahidArda
reviewed
Jun 3, 2024
CahidArda
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary tests for the index client. Instead of only testing the internal commands, we now also test them with the actual client to make sure we don't break anything in the public interface.