Replace uplog with standard logging module (fixes #23) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwaterbury
changed the title
samwaterbury
changed the title
samwaterbury
changed the title
bburns632
approved these changes
Aug 14, 2019
Haoen-Cui
reviewed
Aug 15, 2019
Haoen-Cui
reviewed
Aug 15, 2019
|
I think this is good to go! FYI I don't have merge permission so someone else will have to do it. |
jameslamb
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Thanks @samwaterbury ! @Chronocook and I hope you'll come back and contribute more!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23!
Also: should the
loggerobject be made global like this or shouldlogging.getLogger()be called in local scopes?