We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should use colorblind-accessible when possible.
For example, the test coverage color palette right now uses a red-green color scale. https://github.com/UptakeOpenSource/pkgnet/blob/master/R/PackageFunctionReporter.R#L108
red
green
We could instead try to pick a colorblind safe color scheme from http://colorbrewer2.org
The text was updated successfully, but these errors were encountered:
@jayqi @jameslamb @patrick-boueri (and anyone!!) ,
What do you think of the color palette changing to this palette?
Thank you @jayqi for these simulations of this color palette under different color blindness conditions via https://www.color-blindness.com/coblis-color-blindness-simulator/:
Sorry, something went wrong.
I am comfortable with the palette you proposed, @bburns632 . This is a great change
For anyone coming to this issue from Google, I want to also note that you can list out all the colorblind palettes in RColorBrewer as follows:
RColorBrewer
RColorBrewer::display.brewer.all(colorblindFriendly=TRUE)
hey we can close this now that #141 was closed!
No branches or pull requests
We should use colorblind-accessible when possible.
For example, the test coverage color palette right now uses a
red
-green
color scale.https://github.com/UptakeOpenSource/pkgnet/blob/master/R/PackageFunctionReporter.R#L108
We could instead try to pick a colorblind safe color scheme from http://colorbrewer2.org
The text was updated successfully, but these errors were encountered: