Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorblind accessibility of colors #130

Closed
jayqi opened this issue Nov 18, 2018 · 4 comments
Closed

Colorblind accessibility of colors #130

jayqi opened this issue Nov 18, 2018 · 4 comments

Comments

@jayqi
Copy link
Collaborator

jayqi commented Nov 18, 2018

We should use colorblind-accessible when possible.

For example, the test coverage color palette right now uses a red-green color scale.
https://github.com/UptakeOpenSource/pkgnet/blob/master/R/PackageFunctionReporter.R#L108

We could instead try to pick a colorblind safe color scheme from http://colorbrewer2.org

@bburns632 bburns632 added this to the Release v0.3.0 milestone Nov 30, 2018
@bburns632
Copy link
Collaborator

bburns632 commented Nov 30, 2018

@jayqi @jameslamb @patrick-boueri (and anyone!!) ,

What do you think of the color palette changing to this palette?

image

Thank you @jayqi for these simulations of this color palette under different color blindness conditions via https://www.color-blindness.com/coblis-color-blindness-simulator/:

image

image

@jameslamb
Copy link
Collaborator

I am comfortable with the palette you proposed, @bburns632 . This is a great change

@jameslamb
Copy link
Collaborator

For anyone coming to this issue from Google, I want to also note that you can list out all the colorblind palettes in RColorBrewer as follows:

RColorBrewer::display.brewer.all(colorblindFriendly=TRUE)

@jameslamb
Copy link
Collaborator

hey we can close this now that #141 was closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants