Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update To Test Structure Needed To Align With Upcoming R Version #160

Closed
bburns632 opened this issue Jan 7, 2019 · 2 comments
Closed

Update To Test Structure Needed To Align With Upcoming R Version #160

bburns632 opened this issue Jan 7, 2019 · 2 comments
Labels
update needed an update is needed to align with other dependencies

Comments

@bburns632
Copy link
Collaborator

It appears the paths to test packages have issues with the latest CRAN Hosted r-devel on all platforms. Error logs can be seen HERE.

The R-devel version used to submit v0.3.0 was from December.

Version of R-devel:

  • using R Under development (unstable) (2019-01-05 r75949)

CRAN test version info HERE

Issue in Log (one example):
https://cran.r-project.org/web/checks/check_results_pkgnet.html

     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet//sartre’
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet//milne’
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet’
     Error: ERROR: no packages specified
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet//baseballstats’
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet//sartre’
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet//milne’
     Warning: invalid package ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/pkgnet.Rcheck/00_pkg_src/pkgnet’
     Error: ERROR: no packages specified
     Error in pkgnet:::.BuildTestLib(targetLibPath = Sys.getenv("PKGNET_TEST_LIB")) : 
     Installation of packages in .BuildTestLib failed! (exit code = 1)```
@bburns632 bburns632 added the update needed an update is needed to align with other dependencies label Jan 7, 2019
@bburns632
Copy link
Collaborator Author

The changes introduced in #162 should correct these errors incurred on CRAN's testing infrastructure. These errors stem from the inherit need of this package to test itself on toy packages of a known structure. We have gone to great lengths to remain in compliance with all CRAN policies by conduct testing within a temporary directory (#108). However, despite no issues locally or via the automated TRAVIS checks of pull requests, the creation and later referencing of temporary directories on CRAN's testing infrastructure remains troublesome.

As unit testing is at the discretion of the package authors, we choose to have TRAVIS remain the main vehicle for automated unit testing for this package. Of course, all other tests of package integrity on CRAN will continue, just not custom unit testing.

@jayqi
Copy link
Collaborator

jayqi commented Feb 23, 2019

Resolved by #162.

@jayqi jayqi closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update needed an update is needed to align with other dependencies
Projects
None yet
Development

No branches or pull requests

2 participants