Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Statistics are off #165

Closed
bburns632 opened this issue Jan 22, 2019 · 2 comments
Closed

Network Statistics are off #165

bburns632 opened this issue Jan 22, 2019 · 2 comments
Assignees
Labels

Comments

@bburns632
Copy link
Collaborator

Our network statistics are WAY off somehow. Consider this example:

pkgnet::CreatePackageReport("lubridate")

Package Dependencies

Looks at stats package. It clearly has an inDegree of 1 and outDegree of 3. However, in the table, the values are 3 and 0 respectively.

image

Functional Dependencies

divide_duration_by_difftime is listed as one of the largest inSubgraphs at 81. However, it has no edges. In the repo, it is mentioned just twice: the function dependency

image

image

image

This is a bug.

@bburns632 bburns632 added the bug label Jan 22, 2019
@jayqi
Copy link
Collaborator

jayqi commented Jan 23, 2019

I bet the cause is something like when you're calculating it and then assigning the columns to the data.table, it's in a different order, or maybe something like igraph dropping NAs and then it's tiling the shorter vector.

@bburns632 bburns632 self-assigned this Jan 24, 2019
@bburns632
Copy link
Collaborator Author

bburns632 commented Jan 24, 2019

@jayqi I'm pretty sure it's that. Merges of out of order vectors around here: https://github.com/UptakeOpenSource/pkgnet/blob/master/R/AbstractGraphReporter.R#L124

Working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants