Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that nodes are correctly extracted in FunctionReporter #180

Closed
jameslamb opened this issue Feb 10, 2019 · 2 comments
Closed

Add tests that nodes are correctly extracted in FunctionReporter #180

jameslamb opened this issue Feb 10, 2019 · 2 comments
Labels

Comments

@jameslamb
Copy link
Collaborator

In test-FunctionReporter, we should add tests confirming that pkgnet correctly translates package exported namespaces to nodes.

@bburns632
Copy link
Collaborator

bburns632 commented Feb 10, 2019

I believe THIS TEST on baseballstats confirms that a node is created for each function within the package.

However, if someone has a suggestion on how we can make this testing more robust, especially on edge case R package designs, please feel free to comment here.

@jayqi
Copy link
Collaborator

jayqi commented Feb 23, 2019

This issue is maybe too open ended. In any case, I have new tests in #181 checking the whole extracted network for all three of baseballstats, sartre, and milne. I think this should be good enough, and if we identify new edge cases, we should introduce them to those test packages or as new test packages as needed.

https://github.com/UptakeOpenSource/pkgnet/pull/181/files#diff-672ae504c307217ca3f5678b6473fdd6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants