Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate vignette on latest public versions of lubridate and pkgnet #196

Closed
bburns632 opened this issue Mar 1, 2019 · 1 comment
Closed

Comments

@bburns632
Copy link
Collaborator

We need to recreate the vignette with specific versions of BOTH lubridate and pkgnet and update the "A Deeper Look" with instructions utilizing devtools::install_version() (or some other more R way to install specific versions) to replicate the analysis.

This will prevent #189 from happening again in the future. Considering that #181 is updating the content to align with itself, we can save this vignette update until after the next pushed version to github

@jayqi
Copy link
Collaborator

jayqi commented Mar 2, 2019

I actually disagree with pegging pkgnet version. I think in general, if we're making changes that we anticipate to affect the vignette static content, it's the responsibility of that PR contributor to update the vignette. Additionally, I think before we do a release, we should check the vignette. It makes more sense to me for our vignette to be up-to-date with the latest release of pkgnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants