Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal logger to reduce verbosity #10

Merged
merged 1 commit into from Nov 7, 2017
Merged

Add internal logger to reduce verbosity #10

merged 1 commit into from Nov 7, 2017

Conversation

jameslamb
Copy link
Collaborator

We were repeating this pattern many times:

msg <- "some text"
futile.logger::flog.fatal(msg)
stop(msg)

This will now look like:

msg <- "some text"
log_fatal(msg)

@@ -0,0 +1,26 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

covr,
data.table,
futile.logger,
igraph,
magrittr,
methods,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly importing the methods package. Such attention to detail good sir.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nothing if not a professional

@jameslamb jameslamb merged commit 78f6ba1 into uptake:master Nov 7, 2017
@jameslamb jameslamb deleted the feature/logger branch June 23, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants