-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rough skeleton of documentation (by Sphinx) #130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 8 8
Lines 608 608
=======================================
Hits 579 579
Misses 29 29 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, it looks awesome! Can you please do three things:
- remove all the files in
build/
. For now, until we figure out a strategy to merge our R and Python docs on github-pages, I do not want to check all that HTML into the repo - add
py-pkg/docs/build/
to.gitignore
so no future committers accidentally check these files in - add a
docs_python
recipe to theMakefile
at the repo root (NOT the Sphinx makefile) containing whatever commands are needed to regenerate the docs. Should be something likecd py-pkg/docs && make html
, I think
Once you make those changes, I think it will be good to merge!
…ommand in Makefile. Updated conf.py
Hi @jameslamb , Thanks for the note. I've made the changes accordingly - seems that I cannot submit another pull request on top of the existing one. Can the branch be merged? Is there anything to be added? Best, Clare |
@csyhuang FYI in case you noticed Travis breaking on your most recent commit...not related to your code at all. Sometimes Travis builds just randomly fail because of network problems. I manually rebuilt it and it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this!!!
I cloned your branch and built locally, can confirm it all works! I'm going to create a few more issues on the project for things like updating the style, adding explicit author names to the copyright statement, etc. so if you're interested we'd welcome further contributions.
But this PR as-is definitely addresses the issue. Really really appreciate you spending the time improving our project!!!!
scroll_context_timer (string): A string such as "1m" or "5m" that specifies | ||
how long to keep the scroll context alive between pages for large | ||
queries. Default: "1m" | ||
scroll_context_timer (string): A string such as "1m" or "5m" that specifies how long to keep the scroll context alive between pages for large queries. Default: "1m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Sphinx will recognize lines like this broken by explicit newlines, e.g. putting a \n
at the end of each line.
But I have no strong preference between doing that and what you did here, so this is cool!
Addressing issue #88
Everything generated by Sphinx for the python package is in py-pkg/docs/
Thanks for the fun night!