Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation for get_fields function #67

Merged
merged 2 commits into from
May 24, 2018

Conversation

ankur-srivastava1
Copy link

Fixed the function name in documentation for get_fields() function. Changed it from retrieve_mapping to get_fields.

@jameslamb
Copy link
Collaborator

nice, thank you for doing this! Noting for GH that this addresses #53

Can you please run devtools::document() to refresh the roxygen stuff? Don't worry about dealing with pkgdown...we have so much stuff in flight with the other open PR, pkgdown will get regenned anyway.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just run devtools::document() and commit the changed roxygen docs, then we will get this merged

@jameslamb
Copy link
Collaborator

also @ankur-srivastava1 don't worry about Travis breaking. I looked at the build and it's not related to your change.

@ankur-srivastava1
Copy link
Author

Added get_fields.Rd.

@jameslamb
Copy link
Collaborator

This looks good! Thanks @ankur-srivastava1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants