Split registry management DSL out into module #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why you made the change: Did this because we wanted to enable people to define additional toggle registries within their applications. How the change addresses the need: This enables them doing so by simply including the new Togls::ReleaseToggleRegistryManager module in a class that they define which should represent their additional toggle registry. Example: class MyApp::Togls include ::Togls::ReleaseToggleRegistrtyManager end MyApp::Togls.features do feature(:foo).on feature(:bar).off end if MyApp::Togls.feature(:foo).on? ... end
| @@ -157,4 +157,25 @@ | |||
| }).to_stdout | |||
| end | |||
| end | |||
|
|
|||
| describe "creating additional toggle registries" do | |||
| describe "defining feature toggles in additional registry" do | |||
There was a problem hiding this comment.
You can probably make this the wrapping describe and nuke the creating additional toggle registries
Why you made the change: I did this to make it clearer as to what it is actually testing. This is good all around because software is all about communication of intent, :-)
|
|
drewdeponte
added a commit
that referenced
this pull request
Mar 3, 2016
Split registry management DSL out into module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why you made the change:
Did this because we wanted to enable people to define additional toggle
registries within their applications.
How the change addresses the need:
This enables them doing so by simply including the new
Togls::ReleaseToggleRegistryManager module in a class that they define
which should represent their additional toggle registry. Example: