Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundebug should print to stderr instead of stdout #349

Closed
aep opened this issue Dec 7, 2021 · 1 comment · Fixed by #350
Closed

bundebug should print to stderr instead of stdout #349

aep opened this issue Dec 7, 2021 · 1 comment · Fixed by #350
Assignees
@aep
Labels
enhancement New feature or request

Comments

@aep
Copy link
Contributor

aep commented Dec 7, 2021

it's a rather trivial change,
should i PR?

bun/extra/bundebug/debug.go

Line 104 in 47a60c1

fmt.Println(args...)

@vmihailenco
Copy link
Member

Yes, let's change it but please also add an option bundebug.WithWriter(os.Stdout) for users who would dislike this change.

@vmihailenco vmihailenco added the enhancement New feature or request label Dec 7, 2021
aep added a commit to aep/bun that referenced this issue Dec 7, 2021
@aep
change the default logoutput to stderr
5f8d989 
also add an option to set it to any writer

fixes uptrace#349
@aep aep mentioned this issue Dec 7, 2021
Merged
aep added a commit to aep/bun that referenced this issue Dec 7, 2021
@aep
feat: change the default logoutput to stderr
4bf5773 
also add an option to set it to any writer

fixes uptrace#349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aep aep

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change the default logoutput to stderr aep/bun
2 participants
@aep @vmihailenco