feat: add Join to UpdateQuery #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
force-pushed
the
feat/update-join
branch
from
1436b9b
to
6b85689
Compare
|
@svanharmelen looks good 👍 Could you please update query_test.go with some example? |
svanharmelen
force-pushed
the
feat/update-join
branch
from
6b85689
to
343378d
Compare
Improves readability (IMHO) so thought to implement it.
svanharmelen
force-pushed
the
feat/update-join
branch
from
343378d
to
da3a04e
Compare
|
@vmihailenco added a test (and made sure it succeeds)... Let me know if you need anything else |
|
@vmihailenco anything else you need from my side? Thanks! |
|
Anything I can do to get this one merged and released? Would be nice if we can switch back to this package and not have to rely on a |
|
Can we please merge this @vmihailenco? Anything more needed from my side? Thanks! |
|
@svanharmelen sorry for the delay 👍 |
|
Thanks @vmihailenco! Only thing left would be a new tag that includes these changes... Any plan for that already? |
|
Thanks for the release @vmihailenco 🎉 |
|
@svanharmelen thanks for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course I can remove the second commit if that would block merging this PR!
Fixes #907