fix: set span kind to client for otelgorm

uptrace · May 27, 2022 · 0250bbd · 0250bbd
1 parent 23d10df
commit 0250bbd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/otelgorm/internal/e2etest/e2e_test.go b/otelgorm/internal/e2etest/e2e_test.go
@@ -33,6 +33,7 @@ func TestEndToEnd(t *testing.T) {
 			require: func(t *testing.T, spans []sdktrace.ReadOnlySpan) {
 				require.Equal(t, 1, len(spans))
 				require.Equal(t, "gorm.Row", spans[0].Name())
+				require.Equal(t, trace.SpanKindClient, spans[0].SpanKind())
 
 				m := attrMap(spans[0].Attributes())
 

diff --git a/otelgorm/otelgorm.go b/otelgorm/otelgorm.go
@@ -96,7 +96,7 @@ func (p otelPlugin) Initialize(db *gorm.DB) (err error) {
 
 func (p *otelPlugin) before(spanName string) gormHookFunc {
 	return func(tx *gorm.DB) {
-		tx.Statement.Context, _ = p.tracer.Start(tx.Statement.Context, spanName)
+		tx.Statement.Context, _ = p.tracer.Start(tx.Statement.Context, spanName, trace.WithSpanKind(trace.SpanKindClient))
 	}
 }