-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): Resource & Entity loader/reader components #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP needs more tests
Currently the API lib we use uses `data` as the key in the response object that holds the response body from the API. Our backend APIs use the key `data` in the response JSON to hold the actual data requested. This results in the response data being accessed from by the (odd looking) `response.data.data`. This updates the resource sagas to correctly extract the data. Before this fix results were handed back wrapped in object like: `{data: <actual data here>}`
Exposed through: createResourceHelper
Closes #19 |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 93.07% 87.62% -5.45%
==========================================
Files 14 21 +7
Lines 231 299 +68
Branches 21 34 +13
==========================================
+ Hits 215 262 +47
- Misses 16 36 +20
- Partials 0 1 +1
Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loader Components
These components request resources and return the results. If an entityType is provide that matches a schema that is defined for the entities redux-module it will normalize the resource.
ResourceDetailLoader
ResourceListLoader
Reader Components
These components "read" data from the entity state in the global redux store and return the matching entity.
EntityDetail
EntityList