-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation fixes #34
Conversation
Replaced deprecated curly braces.
Updated regex to support HTTP/2
It would be great to have this merged. cc @mnovozhylov |
1 similar comment
@mnovozhylov unless it has a licence which prohibits changing (which defies the whole purpose of open source code), linking that readme and closing this PR made no sense whatsoever. You're literally declining having a non-breaking improvement merged. |
@Norgul , I appreciate your feedback and engagement. I have to mention, still, that we do not maintain vendor's code. Instead, the library provides proper interface and the mentioned vendor library is just an example. You are free to organize your project in the proper way, and fork or update the vendor's code on your side. |
@mnovozhylov that all sounds reasonable, however Meaning unfortunately that even if I go and fork the package in question and make fixes there, it will do absolutely nothing with regards to this package working. I'm afraid that I'll keep using my branch until I find an alternative. Thanks anyway. |
@mnovozhylov So for me, these two points mean you should maintain the code in the |
Replaced deprecated curly braces, and added regex support for HTTP/2.