Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation fixes #34

Closed
wants to merge 2 commits into from
Closed

Deprecation fixes #34

wants to merge 2 commits into from

Conversation

Norgul
Copy link

@Norgul Norgul commented Aug 7, 2021

Replaced deprecated curly braces, and added regex support for HTTP/2.

Replaced deprecated curly braces.
@Norgul Norgul marked this pull request as draft August 7, 2021 10:44
Updated regex to support HTTP/2
@Norgul Norgul marked this pull request as ready for review August 7, 2021 10:46
@bodva
Copy link

bodva commented Apr 26, 2022

It would be great to have this merged.

cc @mnovozhylov

@mnovozhylov
Copy link
Contributor

1 similar comment
@mnovozhylov
Copy link
Contributor

@Norgul
Copy link
Author

Norgul commented Apr 28, 2022

@mnovozhylov unless it has a licence which prohibits changing (which defies the whole purpose of open source code), linking that readme and closing this PR made no sense whatsoever. You're literally declining having a non-breaking improvement merged.

@mnovozhylov
Copy link
Contributor

@Norgul , I appreciate your feedback and engagement. I have to mention, still, that we do not maintain vendor's code. Instead, the library provides proper interface and the mentioned vendor library is just an example. You are free to organize your project in the proper way, and fork or update the vendor's code on your side.

@Norgul
Copy link
Author

Norgul commented Apr 28, 2022

@mnovozhylov that all sounds reasonable, however vendor-src is a part of this repository and there is no package manager handling its dependencies.

Meaning unfortunately that even if I go and fork the package in question and make fixes there, it will do absolutely nothing with regards to this package working. I'm afraid that I'll keep using my branch until I find an alternative. Thanks anyway.

@bodva
Copy link

bodva commented Apr 28, 2022

@mnovozhylov
Agree with @Norgul notice that the vendor-src is a part of this package because it is included here as a code directly, instead of dependencies.
It doesn't have the sense to link to the library because the library is outdated and looks like it does not have support anymore.

So for me, these two points mean you should maintain the code in the vendor-src the same way you maintain the code of the package itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants