Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phystrix dependency #4

Closed
wants to merge 3 commits into from

Conversation

acanimal
Copy link

I found problems when using physxtrix@2 in my project.

@lcf
Copy link
Contributor

lcf commented Nov 17, 2017

@acanimal what kind of problems?

@acanimal
Copy link
Author

Its about depencies. I tried to use it in a project with phystrix v2 and when adding phystrix-dashboard composer fails because it depends on phyxtrix v1.

@lcf
Copy link
Contributor

lcf commented Nov 18, 2017

@acanimal I see, thank you. We never package the dashboard inside an application where Phystrix is used, I would recommend you making sure it makes sense for you.

However, your request makes perfect sense. The only thing is, would you mind updating the version constraint in your PR in a way that both 1.. and 2.. are allowed? whichever is available

@acanimal
Copy link
Author

Done.

I was working on an example on how to use phystrix. Anyway your note about using phystrix-dashboard inside the main app is a good point.

Cheers

@acanimal
Copy link
Author

Done

@lcf
Copy link
Contributor

lcf commented Nov 19, 2017

I'm getting this when trying to 'composer install'

[UnexpectedValueException]
Could not parse version constraint >=1.: Invalid version string "1."

to avoid going back and forth I fixed it in master myself, please checkout release 1.0.2. I hope this works for you and thank you for bringing up the issue.

@lcf lcf closed this Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants