tamaño automatico de canvas #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 9 9
Lines 696 696
Branches 161 161
=======================================
Hits 596 596
Misses 100 100 ☔ View full report in Codecov by Sentry. |
PalumboN
approved these changes
Mar 20, 2024
| var positionX = | ||
| visuals[i].position.x * cellPixelSize * (windowWidth / widthGame) | ||
| var y = windowHeight - 20 - visuals[i].position.y * cellPixelSize | ||
| var positionX = visuals[i].position.x * cellPixelSize | ||
| var y = gameHeight - visuals[i].position.y * cellPixelSize |
There was a problem hiding this comment.
Acá es dónde pasa la magia? Se podría poner en una función y testear?
Comment on lines
-16
to
+19
| widthGame = size[0] | ||
| gameWidth = size[0] | ||
| gameHeight = size[1] | ||
| resizeCanvas(gameWidth, gameHeight) |
There was a problem hiding this comment.
Acá me perdí un toque, este size es el size del game o del canvas de la pantalla?
There was a problem hiding this comment.
Hola, size es un parámetro que viene desde al backend y representa el ancho y alto del juego (calculado por wollok-ts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR implementa el tamaño automático del canvas, basado en la cantidad y tamaño de las celdas
Nota: la primera vez que se abre el juego, el canvas ocupa toda la pantalla, esto se corrige en el PR #132
Closes #131