Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig #135

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

mind-ar
Copy link
Contributor

@mind-ar mind-ar commented Mar 14, 2024

Este PR agrega la configuración de editorconfig, así todos los colaboradores/as compartimos la misma indentación

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (bcf4129) to head (dda1801).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files           9        9           
  Lines         696      696           
  Branches      161      161           
=======================================
  Hits          596      596           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PalumboN
Copy link
Contributor

Hola @mind-ar,

Qué IDE o herramienta usa ese archivo?
Porque sé que existe un archivo por acá para eso
https://github.com/uqbar-project/wollok-ts-cli/tree/master/.vscode

@PalumboN PalumboN merged commit 618d2dd into uqbar-project:master Mar 20, 2024
3 checks passed
@mind-ar mind-ar deleted the feat-editorconfig branch March 22, 2024 11:42
@mind-ar
Copy link
Contributor Author

mind-ar commented Mar 22, 2024

Qué IDE o herramienta usa ese archivo? Porque sé que existe un archivo por acá para eso https://github.com/uqbar-project/wollok-ts-cli/tree/master/.vscode

Ese archivo lo utiliza el plugin EditorConfig, que lo que tiene de especial es que es soportado por casi todos los IDEs, y ayuda a unificar el formato de los archivos.

@PalumboN
Copy link
Contributor

Okk o sea que mi vscode ya le dan bola a ese archivo y no necesitamos el archivo que menciono?

Podemos abrir un issue para unificar esto?

@mind-ar
Copy link
Contributor Author

mind-ar commented Mar 29, 2024

Listo ahí abrí #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants