Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node lib download #169

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Node lib download #169

merged 3 commits into from
Jul 1, 2024

Conversation

ivojawer
Copy link
Contributor

fix #168
fix #119

Corre un script de node en vez de un .sh, deberia tener menos problemas de compatibilidad.

Tambien aproveche a descargar las libs de game.

@ivojawer ivojawer requested a review from PalumboN June 27, 2024 00:24
Comment on lines +18 to +19
filename: "socket.io.esm.min.js",
url: "http://cdn.socket.io/4.4.1/socket.io.esm.min.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto quedo duplicado, pero el server hace un serve por carpeta, por lo que si quisiera hacer una compartida tambien deberia compartir los archivos del diagrama.

@ivojawer ivojawer marked this pull request as ready for review June 27, 2024 00:36
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joyitaaaaa 💎

@PalumboN PalumboN merged commit e6f4e5c into master Jul 1, 2024
1 check passed
@PalumboN PalumboN deleted the node-lib-download branch July 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants