#1424 type for closures using class type parameters #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClosureTypeAnnotations y sirve para cualquier tipo genérico.
- Includes test plan for all type tests on lists. - Add typing information for list/set/collection/range.
ghost
assigned
npasserini
commented
Jul 16, 2018
| // XPECT type at findSome --> Number | ||
| const findSome = sample.find { x => x.even } | ||
|
|
||
| // method forEach(closure) { self.fold(null, { acc, e => closure.apply(e) }) } |
There was a problem hiding this comment.
Estos tests que siguen no andan, por eso es todo comentario... bah, ni siquiera son tests, pero marca los siguientes pasos de cosas a testear.
| * | ||
| * Por ahora se permite, un poco por compatibilidad hacia atrás. | ||
| */ | ||
| class GenericTypeAnnotation extends SimpleTypeAnnotation<GenericType> { |
There was a problem hiding this comment.
Creo que en un futuro esto debería djar de ser subtipo de annotation
| @@ -0,0 +1,64 @@ | |||
| package org.uqbar.project.wollok.typesystem.constraints.variables | |||
There was a problem hiding this comment.
Es un rename de MinTypeAnalysisResultReporter, no sé por qué no lo muestra bien.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esto es muy básico y requiere más laburo que ya está en marcha pero hasta acá anda así que propongo mergear para no tener luego un PR gigante.