Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1405 - inherited properties are searched in a recursive and isol… #1451

Merged
merged 2 commits into from
Aug 11, 2018

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Aug 8, 2018

…ated method

allMethods efectivamente devuelve todos los métodos heredados, así que lo que planteé fue tener un método recursivo que trabaje las propiedades heredadas a n niveles aparte.

@fdodino fdodino added this to the Wollok v1.7 Gramsci milestone Aug 8, 2018
@ghost ghost assigned fdodino Aug 8, 2018
@ghost ghost added the in progress label Aug 8, 2018
@coveralls
Copy link

coveralls commented Aug 8, 2018

Coverage Status

Coverage increased (+0.03%) to 91.942% when pulling 837ff31 on fix-#1405-unnecessary-validation into a320e14 on dev.

Copy link
Member

@npasserini npasserini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El nombre matchesAllProperties no sé si puede ser confuso.

@fdodino
Copy link
Collaborator Author

fdodino commented Aug 10, 2018

Ok, tiro matchesPropertiesInHierarchy, porque matchesInheritedProperties no es del todo exacto. Debe matchear la propiedad en la clase o bien recorriendo toda su jerarquía. A esta hora no se me ocurre otra.

@fdodino fdodino merged commit 9e99e84 into dev Aug 11, 2018
@fdodino fdodino deleted the fix-#1405-unnecessary-validation branch August 11, 2018 12:47
@ghost ghost removed the in progress label Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants