Fix #1155 - if without else in expression #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
npasserini
approved these changes
Aug 11, 2018
| @@ -1,5 +1,31 @@ | |||
| /* XPECT_SETUP org.uqbar.project.wollok.tests.xpect.WollokXPectTest END_SETUP */ | |||
|
|
|||
| object joaquin { | |||
There was a problem hiding this comment.
Estas validaciones pronto podrían volverse duplicadas porque el type system debería detectar el mismo problema.
Pero bueno, mientras madura el TS podemos mantenerlas.
Otra es pensar si el TS puede no reportar cosas que podemos validar con métodos más sencillos y rápidos, pero no sé si es fácil.
| @@ -624,6 +624,8 @@ class WollokModelExtensions { | |||
| def static dispatch expectsExpression(EObject e) { false } | |||
There was a problem hiding this comment.
No para corregir ahora, pero me dejó un warning la semántica de este método porque sólo mira el padre y no la posición del hijo dentro del padre. Por ejemplo, if (b) x exige que b sea una expresión pero no x (y ambos tienen el mismo container. Más complicado aún if (b) x else y podría exigir que x e y sean expresiones dependiendo del contenedor del contenedor, chan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests. It happened to me last year, during revision of students work.