Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ts null literal #1527

Merged
merged 3 commits into from
Oct 14, 2018
Merged

Ts null literal #1527

merged 3 commits into from
Oct 14, 2018

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Oct 8, 2018

Fixes #1508

This PR only create a generic type variable for each NullLiteral.

@ghost ghost assigned PalumboN Oct 8, 2018
@ghost ghost added the in progress label Oct 8, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.082% when pulling 422c307 on ts-null-literal into bf99d36 on dev.

npasserini
npasserini approved these changes Oct 14, 2018
View reviewed changes
Copy link
Member

@npasserini npasserini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como bien dice el comentario, seguramente en algún momento vamos a querer implementar algo "null safe", pero creo que por ahora esta implementación es aceptable. Y necesaria.

@npasserini npasserini merged commit 38c0e2d into dev Oct 14, 2018
@npasserini npasserini deleted the ts-null-literal branch October 14, 2018 14:38
@ghost ghost removed the in progress label Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npasserini npasserini npasserini approved these changes

Assignees

@PalumboN PalumboN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PalumboN @coveralls @npasserini