Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts object literal #1558

Merged
merged 13 commits into from
Dec 13, 2018
Merged

Ts object literal #1558

merged 13 commits into from
Dec 13, 2018

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Nov 7, 2018

Fix #1523

  1. Este test está comentado por este issue TS Better method type inference when errors exist #1526 que aún está en discusión.
  2. Este otro test está comentado por el punto 3 de mi comentario en el issue TS for Object Literals error #1523 (sobre la forma de calcular los union types para los métodos).
  3. Este método tipa a (Any) => Any por el punto 1 del mismo comentario en el issue TS for Object Literals error #1523

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.179% when pulling aaa7986 on ts-object-literal into 1669e32 on dev.

// XPECT! warnings --> "{ cena } doesn't match with { habla } ... TO CHECK"
// method hacerHablarAHambriento() = self.hacerHablar(hambriento)

// XPECT methodType at hacerHablar(personalidad) --> (({ habla ; cena }|{ habla })) => String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fino y tal vez para otro issue pero el tipo estructural (({ habla ; cena }|{ habla })) debería poder reducirse a { habla }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npasserini
Copy link
Member

Todo esto se ve piola pero hay algún error que hace que no compile el TS.

@PalumboN
Copy link
Contributor Author

No compilaba por un extension method de WMethodContainerExtensions que se había renombrado en dev, muy raro, por ahora con el merge se arregló.
Algo más raro aún es que pasó el test de ArrowListener! Voy a mergear antes de que travis se arrepienta.

@PalumboN PalumboN merged commit cc5dafd into dev Dec 13, 2018
@PalumboN PalumboN deleted the ts-object-literal branch December 13, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants