Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic diagram enhancements #1676

Merged
merged 9 commits into from
Jul 6, 2019
Merged

Dynamic diagram enhancements #1676

merged 9 commits into from
Jul 6, 2019

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Jul 1, 2019

Fixes:

See images and gifs in each issue

@fdodino fdodino added this to the Wollok v.1.8 Hipatia milestone Jul 1, 2019
@fdodino fdodino requested a review from PalumboN July 1, 2019 03:19
@coveralls
Copy link

coveralls commented Jul 1, 2019

Coverage Status

Coverage remained the same at 89.138% when pulling 58a755c on dynamic-diagram-enhancements into 1e59b7d on dev.

def isSet() { typeName.equalsIgnoreCase(SET) }
def isString() { typeName.equalsIgnoreCase(STRING) }
def isNative() { #[BOOLEAN, DATE, PAIR, RANGE].contains(typeName) }
def isCollection() { isList || isSet }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya no existe una forma de saber estas cosas que no sea por el nombre?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No todavía.

@fdodino fdodino merged commit cfa4319 into dev Jul 6, 2019
@fdodino fdodino deleted the dynamic-diagram-enhancements branch July 6, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants