Wollok game features #1750
Merged
Wollok game features #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npasserini
approved these changes
Aug 24, 2019
| try { | ||
| call("image") | ||
| } catch (WollokProgramExceptionWrapper exception) { | ||
| if (exception.messageNotUnderstood) //TODO: Check inverted logic (!) |
There was a problem hiding this comment.
No se puede preguntarle al objeto si entiende el mensaje image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1658 - Adding
DomainExceptionwithsourceattribute.Fix #1736
Fix #1737
Fix #1733
Fix #1746
Esto recontra rompe la compatibilidad hacia atrás, por ende los juegos hechos hasta el año pasado puede que dejen de funcionar. Si los queremos tener andando (por ejemplo en el sitio, que es algo que tengo ganas de hacer) yo diría de esperar (o manejar las versiones) antes de meter esto en Wollok-TS.
Varios de los tests que toqué acá mepa que deberían estar en los sanity.