Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] wollok-language unification #1849

Merged
merged 80 commits into from
Nov 30, 2019
Merged

[WIP] wollok-language unification #1849

merged 80 commits into from
Nov 30, 2019

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Oct 19, 2019

  • adding wollok-language as a submodule
  • removing .wlk lib files from wollok-xtext project and link them from wollok-language
  • Travis build passing
  • AppVeyor build passing (linking files didn't work in Windows, I had to copy files from wollok-language into org.uqbar.project.wollok.lib in appveyor script file)
  • adding sanity test files in org.uqbar.project.tests project as an individual test (as in examples test)
  • removing duplicate tests from wollok-xtext, they will be moved to wollok-language repo (see Sanity Test Refactor wollok-language#22)

Fixes

New test console for wollok-cli

newTestConsole

Running 799 tests

Eclipse changes

Now you have 1301 tests instead of 2400...

eclipseRunningNewTests

and Sanity Tests run inside Eclipse IDE. 🍰

@fdodino fdodino added the WIP Work In Progress - don't merge (for PR) label Oct 19, 2019
@coveralls
Copy link

coveralls commented Oct 20, 2019

Coverage Status

Coverage decreased (-3.9%) to 85.921% when pulling 73d1a16 on adding-wollok-language-project into 70b4f49 on dev.

@fdodino fdodino added Wollok Language Architectural issue: unification of wollok implementations and removed WIP Work In Progress - don't merge (for PR) labels Nov 13, 2019
@fdodino
Copy link
Collaborator Author

fdodino commented Nov 13, 2019

Ready to review @PalumboN @npasserini !
It would be nice to merge it and start using it => I'll add a wiki page to reflect every Wollok Xtext developer should run wollokInstall.sh or wollokInstall.bat script.

@fdodino fdodino added this to the Wollok 1.9.1 milestone Nov 14, 2019
@fdodino
Copy link
Collaborator Author

fdodino commented Nov 21, 2019

@PalumboN , no te olvides de los pobres 😄

@PalumboN
Copy link
Contributor

PalumboN commented Nov 22, 2019 via email

Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente todo! Dejé algunos comentarios que no deberían frenar el merge :)
🚀 🎸

@fdodino fdodino merged commit c08fa5f into dev Nov 30, 2019
@fdodino fdodino deleted the adding-wollok-language-project branch November 30, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wollok Language Architectural issue: unification of wollok implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants