Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1928 REPL Console when stopped should not warn about being outdated #1937

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Sep 5, 2020

See #1928

@fdodino fdodino added this to the 2.0.2 milestone Sep 5, 2020
@coveralls
Copy link

coveralls commented Sep 5, 2020

Coverage Status

Coverage remained the same at 86.195% when pulling 1dc438a on fix-#1928-console-REPL-outdated-only-when-activated into 3b013f2 on dev.

Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@@ -44,4 +44,4 @@ WollokRepl_SYNCED_MESSAGE = Sincronizado
WollokRepl_OUTDATED_MESSAGE = Desactualizado
WollokRepl_SYNCED_TOOLTIP = El proyecto {0} est\u00E1 sincronizado con la sesi\u00F3n de la consola REPL
WollokRepl_OUTDATED_TOOLTIP = El proyecto {0} no est\u00E1 sincronizado con la sesi\u00F3n de la consola REPL. Los cambios que hiciste no estar\u00E1n disponibles en la consola hasta que la reinicies.
WollokRepl_OUTDATED_WARNING_MESSAGE_IN_REPL = \u00A1ATENCI\u00F3N! El archivo original fue modificado, los cambios no tomar\u00E1n efecto hasta que no reinicies la sesi\u00F3n.
WollokRepl_OUTDATED_WARNING_MESSAGE_IN_REPL = \u00A1ATENCI\u00D3N! El archivo original fue modificado, los cambios no tomar\u00E1n efecto hasta que no reinicies la sesi\u00F3n.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambié "ATENCIóN" por "ATENCIÓN" 😄

@PalumboN
Copy link
Contributor

Dejé un comentario en el issue de otro problema (o el mismo creo) relacionado.

@fdodino fdodino merged commit 068d2f8 into dev Sep 15, 2020
@fdodino fdodino deleted the fix-#1928-console-REPL-outdated-only-when-activated branch September 15, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants