Fix type system issues #1991
Merged
Fix type system issues #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdodino
approved these changes
Mar 16, 2021
| @@ -121,7 +128,7 @@ class ConstraintGenerator { | |||
| // TODO Process supertype information: mixins | |||
| parentParameters?.arguments?.forEach[generateVariables] | |||
| members.forEach[generateVariables] | |||
| if (parentParameters !== null) objectParentConstraintsGenerator.add(it) | |||
| if(parentParameters !== null) objectParentConstraintsGenerator.add(it) | |||
There was a problem hiding this comment.
nooooo, ese espacio era lo más! 😆
There was a problem hiding this comment.
Sí, a mí tmb me dolió, me di cuenta en Github 👎
| @@ -31,7 +31,7 @@ class WollokCoreTypeDeclarations extends TypeDeclarations { | |||
| O >> "shortDescription" === #[] => String; | |||
| O >> "kindName" === #[] => String; | |||
| O >> "className" === #[] => String; | |||
| O >> "error" === #[String] => Void; | |||
| O >> "error" === #[String] => THROW_EXCEPTION; | |||
| @@ -121,7 +121,8 @@ class UnifyVariables extends AbstractInferenceStrategy { | |||
| } | |||
| } | |||
|
|
|||
| def dispatch doUnifyWith(GenericTypeInfo t1, GenericTypeInfo t2) { | |||
| def dispatch doUnifyWith(GenericTypeInfo t1, GenericTypeInfo t2) { | |||
| t1.validateRecursiveType(t2) | |||
|
Buenísimo @fdodino, ahora cuando termine el CI mergeo. Vengo trabajando en más cosas pero lo mando a otro PR para ir cerrando issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1751
Fix #1958
Fix #1641
Fix #1965