Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized names. Changed the name of the plugin to htf in the code. #40

Merged
merged 4 commits into from
May 28, 2019

Conversation

mchakra2
Copy link
Contributor

No description provided.

@whitead
Copy link
Collaborator

whitead commented May 28, 2019

You have merge conflicts. Please rebase to master to resolve them.

@pep8speaks
Copy link

pep8speaks commented May 28, 2019

Hello @mchakra2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 25:1: E303 too many blank lines (3)
Line 25:35: E231 missing whitespace after ','
Line 25:80: E501 line too long (90 > 79 characters)

Comment last updated at 2019-05-28 19:48:52 UTC

@@ -235,7 +235,7 @@ You may use a saved TensorFlow model via:

```python
import hoomd, hoomd.md
import hoomd.tensorflow_plugin as htf
import hoomd.htf as htf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be from hoomd import htf instead?

@mchakra2 mchakra2 requested a review from hgandhi2411 May 28, 2019 21:37
@mchakra2 mchakra2 merged commit 14fb18a into master May 28, 2019
@whitead whitead mentioned this pull request May 28, 2019
@whitead whitead deleted the issue25 branch June 2, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants