-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(examples): 01. Quickstart Jupyter Notebook #95
Conversation
Thank you for the contribution! We'll have it reviewed shortly. |
Looks good, a few small changes:
|
Thanks for your reply. So your suggestion is to remove the texts, and leave the title and those code blocks. Am I correct?
|
Great, thanks. Sure leave the conda instructions you mentioned if you found that using the simple instructions caused issues. 2. Ok please leave the initialization flag in then. |
Okay, I updated and pushed another commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think you need add a section to the README saying that the jupyter command that you will be using also agrees with the python version that has hoomd-tf and tensorflow installed. Maybe it is intuitive but it might be unintuitive for some novice users.
@dilnoza92 adding running instructions to the readme sounds like a good idea, but maybe that could be separate from this PR. |
@whitead yes it can be a new PR. |
#93
Added
Quickstart
notebook.