Support x86_64 and i686 architectures
#94
+92
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
changed the title
x86_64 aka amd64 archx86_64 and i686 architectures
|
While I was at it I added i686 support as well now. Maybe you'll find this PR easier to merge than #58 as it has fewer changes on top of latest master and supports more distros. |
lalten
force-pushed
the
amd64-support
branch
2 times, most recently
from
6324b47
to
e19aade
Compare
|
@uraimo friendly ping 🔔 |
|
Would love to see this! |
|
I'd love to see this as well. I'm building for armv7 and aarch64 at the moment - being able to use a single action for x86_64 (and while I still support it, i686) would be great! |
|
@uraimo I rebased this PR branch onto latest master and resolved all conflicts. Would be happy to hear your thoughts on this PR. |
|
Would love to use this also! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions using the
amd64andi686arch will not actually use Qemu to run things.But it makes user's lifes easier by removing the need for special-casing no emulation builds.
The Dockerfiles use the https://hub.docker.com/u/amd64/ organization's containers as base.
Closes #93.