Added android support to cordova-gimbal-bridge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces to increase reliability
|
Looks pretty good. Some of the files have inconsistent spacing (tabs vs spaces) and code style ( |
fixing various bugs with new implementation
|
Tweaked the code a bit and updated formatting for better consistency |
Refactor Android Gimbal bridge
|
I believe this is ready to be merged now |
|
@koga73 We are working on a few more changes for the cordova-urbanairship plugin. After we release it ill merge and release this PR. Thanks for all the work! |
|
@koga73 Everything is released, Thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Android.
Lifted GimbalAdapter from the UA-extensions repo
Added GimbalAdapterService for persistence when the app is in background / closed
Created a JavaScript API for both platforms with the ability to start / stop monitoring
Updated documentation