Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILE-329] Upgrade UATagPreferenceCenter to Xcode 10 & Swift 4.2 #8

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

BrianBatchelder
Copy link
Contributor

This PR updates the Tag Preference Center to Xcode 10 & Swift 4.2. Most of the work was just walking through Xcode's automatic updaters. I also updated the UAPreferenceCenter project file as it seems to have gotten out-of-date.

@BrianBatchelder BrianBatchelder self-assigned this Oct 31, 2018
@BrianBatchelder BrianBatchelder added the mobile-review Review requested from the mobile team. label Oct 31, 2018
@BrianBatchelder BrianBatchelder requested a review from a team October 31, 2018 23:30
@BrianBatchelder BrianBatchelder changed the title Upgrade UATagPreferenceCenter to Xcode 10 & Swift 4.2 [MOBILE-329] Upgrade UATagPreferenceCenter to Xcode 10 & Swift 4.2 Oct 31, 2018
@rlepinski
Copy link
Contributor

👍

Copy link

@marc-scig marc-scig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️

@crow crow added reviewed and removed mobile-review Review requested from the mobile team. labels Nov 1, 2018
@BrianBatchelder BrianBatchelder merged commit ba57c66 into master Nov 1, 2018
@ua-web-ci-bot ua-web-ci-bot deleted the update-to-xcode-10-and-sdk-12 branch November 1, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants