Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDVPlugin class AirshipCordova (pluginName: AirshipCordova) does not exist. #424

Closed
MaximBelov opened this issue Apr 16, 2024 · 8 comments
Closed

Comments

@MaximBelov
Copy link
Contributor

MaximBelov commented Apr 16, 2024

Preliminary Info

Error: The plugin does not exist if the name contains the space Airship Cordova
https://cordova.apache.org/docs/en/12.x/config_ref/#name

What Airship dependencies are you using?

Codebase from
#423

What are the versions of any relevant development tools you are using?

xCode 15.2
cordova 12
cordova-ios 7.0.1
pod 1.15.2

Report

What unexpected behavior are you seeing?

Airship Cordova — Airship Cordova xcworkspace 2024-04-16 16-37-02 urbanairship-cordova – config xml 2024-04-16 16-37-35

What is the expected behavior?

Plugin should work with name contains space as name without space

AirshipCordova — AirshipCordova xcodeproj 2024-04-16 16-41-18

What are the steps to reproduce the unexpected behavior?

Set value for tag name with space
<widget ...> <name>Airship Cordova</name> </widget>

Do you have logging for the issue?

@rlepinski
Copy link
Contributor

What issue is this causing?

@MaximBelov
Copy link
Contributor Author

MaximBelov commented Apr 16, 2024

Api from the plugin AirshipCordova is not available
if app name contains space <widget ...> <name>Airship Cordova</name> </widget>

Xcode Debug output
CDVPlugin class AirshipCordova (pluginName: AirshipCordova) does not exist

@rlepinski
Copy link
Contributor

Cool, get it taken care of today/tomorrow. We are working on an 18.1 release of the iOS SDK that we will use in next update.

Any reason this was not obvious in the sample app we have?

@MaximBelov
Copy link
Contributor Author

MaximBelov commented Apr 16, 2024

@MaximBelov
Copy link
Contributor Author

Reproduce

  1. Change name to Test Airship
    <name>Test</name>
  2. Create ios app
  3. Run on device

@rlepinski
Copy link
Contributor

The CI is not that awesome, just does bare minimum to make sure things build. I was running it locally though and didnt notice. Ill try your steps. Thank you!

@rlepinski
Copy link
Contributor

What a weird error. Fixed if I add this to the plugin:

@objc(AirshipCordova)

@MaximBelov
Copy link
Contributor Author

Fixed
Thank you

rlepinski added a commit that referenced this issue Apr 18, 2024
* Update to proxy 6.0.0

* [GH-424] Fix plugin not found if package contains a space

* Fix warning

* Changelog

* Fix highlighting

* Fix version

* Other version

* More versions

---------

Co-authored-by: David <jdavidcrow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants