Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed to restore plugin "cordova-airship" #422

Merged
merged 5 commits into from Mar 25, 2024

Conversation

MaximBelov
Copy link
Contributor

What do these changes do?

Update plugin id

Why are these changes necessary?

The error will be fixed

urbanairship-cordova – reproduce sh 2024-03-25 19-05-39

How to reproduce

See
https://github.com/MaximBelov/urbanairship-cordova/blob/15.0.0-restore-plugin/cordova-id-issue/reproduce.sh

./cordova-id-issue/reproduce.sh

Failed to restore plugin "cordova-airship". You might need to try adding it again. Error: Error: Command failed with exit code 1: npm view cordova-airship --json
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/cordova-airship - Not found

How did you verify these changes?

add to package.json
"@ua/cordova-airship": "github:MaximBelov/urbanairship-cordova#15.0.0-custom",

Verification Screenshots:

Anything else a reviewer should know?

@MaximBelov MaximBelov requested a review from a team as a code owner March 25, 2024 17:19
@MaximBelov
Copy link
Contributor Author

@crow

Also, we can delete deprecated plugin cordova-plugin-whitelist

https://github.com/urbanairship/urbanairship-cordova/blob/main/config_sample.xml#L15

https://www.npmjs.com/package/cordova-plugin-whitelist

image

@crow crow merged commit 8a3f7b1 into urbanairship:main Mar 25, 2024
2 checks passed
@MaximBelov MaximBelov deleted the failed-to-restore-plugin branch March 25, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants