Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to use Kotlin + Coroutines over deprecated AsyncTask #227

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

ed-george
Copy link
Contributor

As Android is now 'Kotlin first', this PR removes the outdated and deprecated use of AsyncTask in the example API documentation and replaces it with a Kotlin equivalent

Remove outdated and deprecated use of AsyncTask
@Artaud
Copy link
Collaborator

Artaud commented Sep 1, 2020

Thanks a lot for this! As there might be lots of legacy projects in the wild, I'd keep that Java example around, we could do a tab switcher with both Java and Kotlin code. If you want to do this, please do, otherwise I'll use your Kotlin implementation and put it in tabs switcher.

@ed-george
Copy link
Contributor Author

Not a problem, I am more than happy to contribute to great projects such as this!

Are there existing examples of a tab switcher on the site? I am more than happy to update my PR accordingly.

I would still advise against promoting the use of AsyncTask for Java though, it is no longer the preferred way in Android to take work off the main thread. Happy to hear your opinion on this.

@Artaud
Copy link
Collaborator

Artaud commented Sep 1, 2020

We've discussed it with @petrnalevka and settled on going with Kotlin only....thanks a lot, I'm merging your PR!

@Artaud Artaud merged commit 1e8258e into urbandroid-team:master Sep 1, 2020
@ed-george
Copy link
Contributor Author

Thanks a lot - will continue to help improve where I can 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants