[WIP] Refactor queue and add DB and Redis implementation. #27
Conversation
petrabarus
force-pushed
the
add-db-redis-queue
branch
2 times, most recently
from
abc784c
to
eb2f544
Compare
petrabarus
force-pushed
the
add-db-redis-queue
branch
from
eb2f544
to
eb67933
Compare
petrabarus
force-pushed
the
add-db-redis-queue
branch
3 times, most recently
from
747f731
to
cdebd00
Compare
petrabarus
force-pushed
the
add-db-redis-queue
branch
from
cdebd00
to
c7a4a9f
Compare
| @@ -94,29 +205,96 @@ public function run(Job $job) { | |||
| $id = $job->route; | |||
| } | |||
| \Yii::error("Fatal Error: Error running route '{$id}'. Message: {$e->getMessage()}", 'yii2queue'); | |||
| throw new \yii\base\Exception("Error running route '{$id}'. Message: {$e->getMessage()}. File: {$e->getFile()}[{$e->getLine()}]. Stack Trace: {$e->getTraceAsString()}", 500); | |||
| throw new \yii\base\Exception( | |||
There was a problem hiding this comment.
Ideally the error/exception handler is an attribute / compose-able, so people can change the handler with what they want. Maybe they don't want to have \Yii::error, or maybe they want specific job to have warning instead of error, or maybe they want different output format so it can easily parsed.
There was a problem hiding this comment.
Agree, since there is a new method to release a job to handle queue like DB and Redis, unlike SQS, that have to manually make the job visible, we should have an error handler for this. So there is three types of job execution: 1) success (true), 2) fail (false) and 3) error (Exception).
Add test for run method Add purge method Add size method.
| @@ -18,7 +17,8 @@ | |||
| * @author Petra Barus <petra.barus@gmail.com> | |||
| * @since 2015.02.24 | |||
| */ | |||
| class SqsQueue extends Queue { | |||
| class SqsQueue extends Queue | |||
There was a problem hiding this comment.
change the namespace to namespace UrbanIndo\Yii2\Queue\Queues;
Queue class is located on this path Urbanindo\Yii2\Queue\Queue;
so, please add use Urbanindo\Yii2\Queue\Queue;
[WIP] Refactor queue and add DB and Redis implementation.
No description provided.