Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:begin bugs and improvements #1

Closed
johncburnham opened this issue Aug 27, 2013 · 0 comments
Closed

:begin bugs and improvements #1

johncburnham opened this issue Aug 27, 2013 · 0 comments
Assignees
@cgyarvin
Labels
bug enhancement

Comments

@johncburnham
Copy link
Contributor

  • :begin looks like it exits to submarine rather than destroyer. It's actually the destroyer but it displays the sub address.
  • extra space and parens for middlename and nickname still displayed (i.e. [John () Burnham])
  • Add some section separators. e.g "-------------"
  • This text is clunky: "For example, we'll ask for the year (not day) you were born,
    because your age is easy to guess in person, doesn't change,
    and has a big effect on how people perceive you." Conflates age and DOB. Your age does change, your DOB does not.
  • What does an %anon or a %punk fill out for the cert details?
@ghost ghost assigned cgyarvin Aug 27, 2013
@17Genr 17Genr mentioned this issue Sep 25, 2013
Closed
@cgyarvin cgyarvin mentioned this issue Oct 3, 2013
Closed
@bvschwartz bvschwartz mentioned this issue Dec 7, 2013
Closed
@ghost ghost mentioned this issue Dec 24, 2013
Closed
mrdomino pushed a commit that referenced this issue Mar 31, 2014
@bnoordhuis
Revert "unix: avoid iterating over all async handles"
b7f38b1 
This reverts commit 209abba.

Fixes the following SIGSEGV:

  (gdb) f 1
  #1  0x00007fc084683aec in uv__async_io (loop=0x7fc0848e0b40,
  handle=0x7fc0848e0c78, events=1) at src/unix/async.c:175
  175             ASYNC_CB(h)
  (gdb) list
  170
  171         /* If we need to sweep all handles anyway - skip this loop */
  172         if (!loop->async_sweep_needed) {
  173           for (i = 0; i < end; i += sizeof(h)) {
  174             h = *((uv_async_t**) (buf + i));
  175             ASYNC_CB(h)
  176           }
  177         }
  178
  179         bytes -= end;
  (gdb) print *h
  $1 = {close_cb = 0x184e1b0, data = 0x18d9520, loop = 0x7fc0848e0b40,
  type = 49, handle_queue = {prev = 0x18dae10, next = 0x7860c0}, flags = 32,
  next_closing = 0x1863b40, pending = 0, async_cb = 0x31,
  queue = {prev = 0x18dae50, next = 0x7860c0}}
  (gdb)

It looks like the async handle gets closed or otherwise becomes invalid before
the sweep is executed.

Fixes #603.
@cgyarvin cgyarvin mentioned this issue May 23, 2014
Closed
@philipcmonk philipcmonk mentioned this issue Aug 29, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgyarvin cgyarvin

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgyarvin @johncburnham