Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way one is supposed to use the Nock spec is by repeatedly going through the reduction rules from top to bottom, and applying the first rule that matches. Some rules (for
10
and+
) appear to be in the wrong order: a more general rule is above a more specific rule, making the latter unreachable. It looks like this kind of issue has been around since Nock 8K.To illustrate, I've modified the 5K spec. Perhaps that's heretical, though! Let me know if I should have proposed a 4K spec, or done something else.