Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem::copy() segfault #73

Closed
drbeefsupreme opened this issue Aug 29, 2023 · 1 comment
Closed

mem::copy() segfault #73

drbeefsupreme opened this issue Aug 29, 2023 · 1 comment
Assignees

Comments

@drbeefsupreme
Copy link
Contributor

drbeefsupreme commented Aug 29, 2023

cargo run ./test_data/shax.jam
Segmentation fault (core dumped)

This is a regression caused by #60 . I am still working out the parameters under which it happens, but I at least have an example: a jamfile of [[shax 0x1] 9 2 10 [6 0 3] 0 2], produced on a ship that has all of the math %sham jets implemented in hoon.hoon. So far, the layer 1 and 2 Hoon standard library calls that I've tried have worked fine, but I've only tried a handful. +shax is in layer 3.

Ares writes the jammed input to NockStack fine, but falls over when it gets to cue. I tried pumping up the amount of memory Ares up til the point that the machine could not allocate it to see if it was just using an absurd amount of memory, but this didn't result in a success.

This jamfile runs fine on Ares pre split-stack, so it is not caused by the sham jets.

https://github.com/urbit/ares/blob/jon/cue-fix/rust/ares/test_data/shax.jam

@drbeefsupreme drbeefsupreme self-assigned this Aug 29, 2023
@drbeefsupreme
Copy link
Contributor Author

drbeefsupreme commented Aug 29, 2023

Ok, looks like cue finishes fine. It's actually a problem with mem::copy(), called during preserve() as the last step of running cue().

@drbeefsupreme drbeefsupreme changed the title cue memory issue mem::copy() segfault Aug 29, 2023
drbeefsupreme added a commit that referenced this issue Aug 29, 2023
drbeefsupreme added a commit that referenced this issue Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant