Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle %spot and %mean hints to produce stack traces #59

Merged
merged 70 commits into from
Oct 4, 2023
Merged

Handle %spot and %mean hints to produce stack traces #59

merged 70 commits into from
Oct 4, 2023

Conversation

ashelkovnykov
Copy link
Contributor

@ashelkovnykov ashelkovnykov commented Jun 8, 2023 •
edited

Enables stack traces to be printed on error and at will (using the %hela hint).

Summary:

  • Introduces a new test pill and partial hoon.hoon environment
  • Introduces virtualization
  • Reorganizes jets into logical groupings
  • Adds jets for:
    • +cap
    • +mas
    • +rap
    • +lent
  • Adds partial jets for:
    • +mink
    • +scow
  • Adds interpreter handling for the following hints:
    • %spot
    • %mean
    • %hela
  • Fixes %slog hint handling

@ashelkovnykov ashelkovnykov marked this pull request as draft June 22, 2023 05:28
@ashelkovnykov ashelkovnykov force-pushed the as/trace branch 2 times, most recently from c163400 to c513bda Compare June 27, 2023 23:11
@ashelkovnykov ashelkovnykov force-pushed the as/trace branch 3 times, most recently from 2b07d91 to 6b98099 Compare August 24, 2023 15:57
@ashelkovnykov ashelkovnykov marked this pull request as ready for review September 16, 2023 04:42
@ashelkovnykov ashelkovnykov changed the title WIP: handle %spot hints to produce stack traces Handle %spot and %mean hints to produce stack traces Sep 16, 2023
@ashelkovnykov ashelkovnykov mentioned this pull request Sep 19, 2023
Closed
eamsden
eamsden reviewed Sep 28, 2023
View reviewed changes
rust/ares/src/mem.rs Outdated Show resolved Hide resolved
eamsden
eamsden requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@eamsden eamsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mean stack slot allocation should be done by passing 1 more to frame_push() in interpreter::push_formula, not by altering the format of frames generally.

eamsden
eamsden requested changes Oct 4, 2023
View reviewed changes
rust/ares/src/interpreter.rs Outdated Show resolved Hide resolved
rust/ares/src/noun.rs Outdated Show resolved Hide resolved
rust/ares/src/noun.rs Outdated Show resolved Hide resolved
@eamsden eamsden merged commit a156b40 into status Oct 4, 2023
2 checks passed
@eamsden eamsden deleted the as/trace branch October 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamsden eamsden eamsden approved these changes

@joemfb joemfb Awaiting requested review from joemfb

@philipcmonk philipcmonk Awaiting requested review from philipcmonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashelkovnykov @eamsden